RFR: 8345327: JDK 24 RDP1 L10n resource files update
Pavel Rappo
prappo at openjdk.org
Tue Dec 10 15:46:38 UTC 2024
On Thu, 5 Dec 2024 22:36:12 GMT, Justin Lu <jlu at openjdk.org> wrote:
> Please review this PR which contains the open L10n drop changes for RDP1.
>
> I recommend viewing the improved diffs which are built out by Jon's tool here: https://cr.openjdk.org/~jlu/output/. As always, I can not confirm the correctness on the quality of the translations themselves.
>
> Generally speaking, observed differences in punctuation can be attributed to language rules. Any keys requiring localization that came in after the JDK was submitted for translations will be handled in the RDP2 L10n drop.
I cannot verify correctness of translation, but I can review this PR generally for `jdk.javadoc`.
>From what I can see, the changes are only to the property files, which is expected from the PR title. The keys from English files 1-1 match the keys from non-English files: there are no missing or extra keys.
>From that point of view, the changes to `jdk.javadoc` look good.
-------------
Marked as reviewed by prappo (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/22588#pullrequestreview-2492753063
More information about the compiler-dev
mailing list