RFR: 8345263: Make sure that lint categories are used correctly when logging lint warnings [v3]

Jan Lahoda jlahoda at openjdk.org
Fri Dec 13 11:47:38 UTC 2024


On Fri, 13 Dec 2024 09:49:39 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

> I'm ready to integrate. I have, however, a question. We also have other localized `compiler.properties` files:
> 
>     * compiler_de.properties
> 
>     * compiler_ja.properties
> 
>     * compiler_zh.properties
> 
> 
> Eyeballing, it seems that these files seem to also be correctly annotated. Should I do anything in particular here?

I assume you mean the `# 0: symbol` annotations, right? I would expect that not to matter at all for the non-generic/non-English files: the generic/English properties bundle should be used to generate the access classes, and the other languages are only used for provide correct key->value mapping, and should be (I hope) ignored w.r.t. the annotations.

So, I would expect that there should be nothing to do? (And even if something was needed, we usually do not modify the language-specific property files.)

Do I miss something?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22553#issuecomment-2541266395


More information about the compiler-dev mailing list