RFR: 8346232: Remove leftovers of the jar --normalize feature
Justin Lu
jlu at openjdk.org
Mon Dec 16 17:17:40 UTC 2024
On Sun, 15 Dec 2024 09:23:47 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>>> We don't usually touch the translated resources. [...] For removal then it's probably okay.
>>
>> What's your recommendation here? Happy to revert changes to translated files, keeping the delete in `jar.properties`, if so desirable.
>>
>> This would rely on Oracle's translation update process catching the remval and update it, ideally in all translations, not only those supported by Oracle JDK, right?
>
>> What's your recommendation here? Happy to revert changes to translated files, keeping the delete in `jar.properties`, if so desirable.
>>
>> This would rely on Oracle's translation update process catching the remval and update it, ideally in all translations, not only those supported by Oracle JDK, right?
>
> I think what you have is okay, I'm just saying that we don't usually touch translations when making changes.
>
> Oracle does a refresh the de, ja, and zh_CN translations in each release so I assume the lines you removed will get removed by the next update anyway. @justin-curtis-lu knows more about this "process". I don't know if anyone funds or maintains the other translations now, it's possible that some of these have bit rotted in recent years.
Yes, removing them is fine here. Otherwise we would have caught them during the L10n update anyways.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22751#discussion_r1887205885
More information about the compiler-dev
mailing list