RFR: 8345327: JDK 24 RDP1 L10n resource files update [v3]
Naoto Sato
naoto at openjdk.org
Mon Dec 16 19:23:55 UTC 2024
On Mon, 16 Dec 2024 19:20:54 GMT, Justin Lu <jlu at openjdk.org> wrote:
>> Please review this PR which contains the open L10n drop changes for RDP1.
>>
>> I recommend viewing the improved diffs which are built out by Jon's tool here: https://cr.openjdk.org/~jlu/output/. As always, I can not confirm the correctness on the quality of the translations themselves.
>>
>> Generally speaking, observed differences in punctuation can be attributed to language rules. Any keys requiring localization that came in after the JDK was submitted for translations will be handled in the RDP2 L10n drop.
>
> Justin Lu has updated the pull request incrementally with two additional commits since the last revision:
>
> - Merge remote-tracking branch 'origin/JDK-8345327-L10N' into JDK-8345327-L10N
> - implement Naoto's review
LGTM
-------------
Marked as reviewed by naoto (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/22588#pullrequestreview-2507065268
More information about the compiler-dev
mailing list