RFR: 8346294: Invalid lint category specified in compiler.properties [v2]

[Maurizio Cimadamore]

On Mon, 16 Dec 2024 19:21:54 GMT, Archie Cobbs <acobbs at openjdk.org> wrote:

>> Please review this fix for an incorrect `lint:` tag in `compiler.properties`, plus an adjustment to the build process to automatically detect and fail the build in case of any similar typos in the future.
>
> Archie Cobbs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Cleanups & refactoring based on review suggestions.

Marked as reviewed by mcimadamore (Reviewer).

src/jdk.compiler/share/classes/com/sun/tools/javac/code/Lint.java line 451:

> 449:         public void visitConstant(Attribute.Constant value) {
> 450:             if (value.type.tsym == syms.stringType.tsym) {
> 451:                 LintCategory.get((String)value.value)

I think use of `Optional` makes sense here too, so bonus point for the extra consolidation!

-------------

PR Review: https://git.openjdk.org/jdk/pull/22769#pullrequestreview-2507083357
PR Review Comment: https://git.openjdk.org/jdk/pull/22769#discussion_r1887385740