RFR: 8323605: Java source launcher should not require `--source ...` to enable preview [v3]

Maurizio Cimadamore mcimadamore at openjdk.org
Tue Feb 6 15:59:54 UTC 2024


On Tue, 6 Feb 2024 14:06:07 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> Please review this PR targeting the source launcher that instead of throwing an error reading _"--enable-preview must be used with --source"_ adds the required compiler arguments on-the-fly.
>> 
>> The add arguments are `--release` and `feature`, with `feature` being the release feature number of the current Java runtime as acquired by `Runtime.version().feature()`.
>
> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove now outdated workaround
>   
>   [skip ci]

Looks good!

-------------

Marked as reviewed by mcimadamore (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17731#pullrequestreview-1865632395


More information about the compiler-dev mailing list