RFR: JDK-8298405: Support Markdown in Documentation Comments [v28]

[Pavel Rappo]

On Thu, 8 Feb 2024 15:38:26 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> test/langtools/jdk/javadoc/tool/sampleapi/lib/sampleapi/generator/ModuleGenerator.java line 49:
>> 
>>> 47: import sampleapi.util.PoorDocCommentTable;
>>> 48: 
>>> 49: import static com.sun.tools.javac.parser.Tokens.Comment.CommentStyle.JAVADOC;
>> 
>> To clarify, the change to this file is that you removed two unused imports, right?
>
> Ping. Maybe if it is not essential, we could remove that change, to keep PR more focused.

Okay I can see that you tried to revert the change to that file and published a [PR] to optimise imports separately. Sadly, the "revert" introduced even more churn. Here's my proposal, which might not be elegant but does the job:


git checkout 8298405.doclet-markdown-v3
git diff -R head --not upstream/master -- test/langtools/jdk/javadoc/tool/sampleapi/lib/sampleapi/generator/ModuleGenerator.java | git apply
git commit -am "Revert all changes to ModuleGenerator.java"


If you have any issues with that snippet, ping me out of band; I hope the intent of the snippet is clear though.

[PR]: https://github.com/openjdk/jdk/pull/17782

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16388#discussion_r1484477033