RFR: 8324736: Invalid end positions for EMPTY_STATEMENT [v2]

Vicente Romero vromero at openjdk.org
Sat Feb 24 01:19:56 UTC 2024


On Sat, 24 Feb 2024 00:29:11 GMT, Archie Cobbs <acobbs at openjdk.org> wrote:

>> In the fix for [JDK-8305671](https://bugs.openjdk.org/browse/JDK-8305671), an `EMPTY_STATEMENT` representing a lone semicolon was being created with the wrong source code position. The bug was that the starting position needed to be captured prior to advancing to the next token, not after.
>
> Archie Cobbs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge branch 'master' into JDK-8324736
>  - Fix bug where source positions got reversed.

lgtm

-------------

Marked as reviewed by vromero (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17595#pullrequestreview-1899149660


More information about the compiler-dev mailing list