RFR: JDK-8042981: Strip type annotations in Types' utility methods [v2]
Liam Miller-Cushon
cushon at openjdk.org
Wed Jan 3 23:29:40 UTC 2024
On Sun, 26 Jun 2022 22:52:43 GMT, Joe Darcy <darcy at openjdk.org> wrote:
>> Early review for JDK-8042981: "Strip type annotations in Types' utility methods". I work more often in the Element world rather than the Type word of the annotation processing APIs.
>>
>> The type annotations on primitive types are *not* cleared by the existing annotation clearing mechanisms. I suspect Type.Visitor is missing a case for primitive types. Someone with familiarity with javac's type modeling should take a look; thanks.
>
> Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>
> - Update visitor; all langtools regression tests pass.
> - Merge branch 'master' into JDK-8042981
> - JDK-8042981: Strip type annotations in Types' utility methods
I cleaned up the approach described in https://github.com/openjdk/jdk/pull/8984#issuecomment-1806211798 and have a draft with those changes applied on top of the work in this PR: https://github.com/openjdk/jdk/pull/17256. It passes the tests added in this PR, with the disabled cases re-enabled.
@jddarcy what do you think of that approach?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/8984#issuecomment-1876104743
More information about the compiler-dev
mailing list