RFR: 8323057: Recoverable errors may be reported before unrecoverable errors when annotation processing is skipped

[Vicente Romero]

On Fri, 5 Jan 2024 19:51:35 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

> When annotation processing is requested, some errors reported during enter may be resolved by the annotation processors. So, javac stashes the errors from enter aside. When an error that cannot be resolved by annotation processing is found in the stashed errors, the annotation processors all the errors will be printed.
> 
> This may be confusing if there's one important non-resolvable error, hidden among many errors that would be resolved by the annotation processors. The proposal herein is therefore to first print the not-recoverable errors, and only then the recoverable errors, when the errors are stashed away and then re-printed.

looks good, minor suggestion, there is no need for a re-review

test/langtools/tools/javac/processing/errors/TestErrorOrder.java line 69:

> 67:         Path src = outerBase.resolve("src");
> 68:         tb.writeJavaFiles(src,
> 69:                           "package t;\n" +

please consider using text blocks

-------------

Marked as reviewed by vromero (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17286#pullrequestreview-1816278586
PR Review Comment: https://git.openjdk.org/jdk/pull/17286#discussion_r1449255942