RFR: JDK-8042981: Strip type annotations in Types' utility methods [v3]

Joe Darcy darcy at openjdk.org
Thu Jan 11 19:31:32 UTC 2024


> Early review for JDK-8042981: "Strip type annotations in Types' utility methods". I work more often in the Element world rather than the Type word of the annotation processing APIs.
> 
> The type annotations on primitive types are *not* cleared by the existing annotation clearing mechanisms. I suspect Type.Visitor is missing a case for primitive types. Someone with familiarity with javac's type modeling should take a look; thanks.

Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:

 - Merge branch 'master' into JDK-8042981
 - Intermediate commit; add stripAnnotations method.
 - Merge branch 'master' into JDK-8042981
 - Merge branch 'master' into JDK-8042981
 - Update visitor; all langtools regression tests pass.
 - Merge branch 'master' into JDK-8042981
 - JDK-8042981: Strip type annotations in Types' utility methods

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/8984/files
  - new: https://git.openjdk.org/jdk/pull/8984/files/0dacb981..61cf9717

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=8984&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=8984&range=01-02

  Stats: 2480805 lines in 22680 files changed: 1276520 ins; 922281 del; 282004 mod
  Patch: https://git.openjdk.org/jdk/pull/8984.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/8984/head:pull/8984

PR: https://git.openjdk.org/jdk/pull/8984


More information about the compiler-dev mailing list