RFR: JDK-8323684: TypeMirror.{getAnnotationsByType, getAnnotation} return uninformative results

Joe Darcy darcy at openjdk.org
Tue Jan 16 20:50:25 UTC 2024


On Fri, 12 Jan 2024 22:29:30 GMT, Joe Darcy <darcy at openjdk.org> wrote:

> Initial implementation to make TypeMirror.{getAnnotationsByType, getAnnotation} functional; tests to follow.

> Initial implementation to make TypeMirror.{getAnnotationsByType, getAnnotation} functional; tests to follow.
> ### Progress
> 
>     * [ ]  Change must be properly reviewed (1 review required, with at least 1 [Reviewer](https://openjdk.org/bylaws#reviewer))
> 
>     * [x]  Change must not contain extraneous whitespace
> 
>     * [x]  Commit message must refer to an issue
> 
> 
> ### Issue
> 
>     * [JDK-8323684](https://bugs.openjdk.org/browse/JDK-8323684): TypeMirror.{getAnnotationsByType, getAnnotation} return uninformative results (**Bug** - P4)
> 
> 
> ### Reviewing
> Using `git`
> Using Skara CLI tools
> Using diff file

The regression tests changes as written check both declaration and type annotations. Given that the type annotation code is shared for all kinds of types, the testing on one shape of type should be adequate from a regression testing perspective.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17410#issuecomment-1894486674


More information about the compiler-dev mailing list