RFR: JDK-8323684: TypeMirror.{getAnnotationsByType, getAnnotation} return uninformative results [v3]

Joe Darcy darcy at openjdk.org
Thu Jan 18 00:55:20 UTC 2024


On Thu, 18 Jan 2024 00:34:21 GMT, Joe Darcy <darcy at openjdk.org> wrote:

>> Initial implementation to make TypeMirror.{getAnnotationsByType, getAnnotation} functional; tests to follow.
>
> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Implement review feedback on regression test.

src/jdk.compiler/share/classes/com/sun/tools/javac/code/AnnoConstruct.java line 53:

> 51:  * or deletion without notice.</b></p>
> 52:  */
> 53: public abstract sealed class AnnoConstruct implements AnnotatedConstruct

@lahodaj or @vicente-romero-oracle , any thoughts on using sealed/non-sealed in javac in this way?

If I don't here back from you on this point, I'll revert use of sealed/non-sealed before pushing. Thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17410#discussion_r1456684651


More information about the compiler-dev mailing list