RFR: JDK-8042981: Strip type annotations in Types' utility methods [v10]
Joe Darcy
darcy at openjdk.org
Sat Jan 20 00:11:30 UTC 2024
On Fri, 19 Jan 2024 19:30:01 GMT, Liam Miller-Cushon <cushon at openjdk.org> wrote:
>> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Augment tests.
>
> test/langtools/tools/javac/processing/model/util/types/TestAnnotationStripping.java line 148:
>
>> 146: else {
>> 147: // Previously, was likely getting by-catch of annotations
>> 148: // on element declartions, can likely just print the size
>
> typo: `s/declartions/declarations`
>
> And per the explanation in this comment, I think the commented-out case for `jdk.internal.ValueBased` can be removed if the test passes without it
Pushed this and some other regression test cleanups/augmentations.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/8984#discussion_r1460035752
More information about the compiler-dev
mailing list