RFR: 8323815: Source launcher should find classes with $ in names

ExE Boss duke at openjdk.org
Tue Jan 23 15:32:27 UTC 2024


On Tue, 23 Jan 2024 07:06:41 GMT, Christian Stein <cstein at openjdk.org> wrote:

> Please review this fix to make the multi-file source-code launcher find classes with `$` in names, including names of packages, names of compliation units, and also names of enclosed types.
> 
> Tested tier1-3

test/langtools/tools/javac/launcher/MultiFileSourceLauncherTests.java line 89:

> 87:                     """);
> 88:         var pq = Files.createDirectories(base.resolve("p/q"));
> 89:         Files.writeString(pq.resolve("Unit$123.java"),

Maybe keep both tests?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17526#discussion_r1463458479


More information about the compiler-dev mailing list