RFR: JDK-8175386: Clarify exception behavior of Types utility methods

Jonathan Gibbons jjg at openjdk.org
Wed Jan 24 00:14:27 UTC 2024


On Mon, 22 Jan 2024 21:51:57 GMT, Joe Darcy <darcy at openjdk.org> wrote:

> Incremental improvements and clarifications in the specification of Types.

Fix duplicate entry

src/java.compiler/share/classes/javax/lang/model/util/Types.java line 46:

> 44:  * {@linkplain TypeKind#PACKAGE packages} and {@linkplain
> 45:  * TypeKind#MODULE modules} are generally out of scope for these
> 46:  * methods.

Do you want to better specify the behavior for the "out of scope" types, such as _Unless otherwise specified, `IllegalArgumenntException` will be thrown when a method is called with an inappropriate argument._

src/java.compiler/share/classes/javax/lang/model/util/Types.java line 252:

> 250:      * @param componentType  the component type
> 251:      * @throws IllegalArgumentException if the component type is not valid for
> 252:      *          an array, including executable, package, module, executable, and wildcard types

duplicate `executable`

-------------

Changes requested by jjg (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17523#pullrequestreview-1840154314
PR Review Comment: https://git.openjdk.org/jdk/pull/17523#discussion_r1464139144
PR Review Comment: https://git.openjdk.org/jdk/pull/17523#discussion_r1464139289


More information about the compiler-dev mailing list