RFR: JDK-8175386: Clarify exception behavior of Types utility methods [v3]

Joe Darcy darcy at openjdk.org
Wed Jan 24 01:12:40 UTC 2024


On Wed, 24 Jan 2024 00:11:13 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Implement review feedback.
>
> src/java.compiler/share/classes/javax/lang/model/util/Types.java line 46:
> 
>> 44:  * {@linkplain TypeKind#PACKAGE packages} and {@linkplain
>> 45:  * TypeKind#MODULE modules} are generally out of scope for these
>> 46:  * methods.
> 
> Do you want to better specify the behavior for the "out of scope" types, such as _Unless otherwise specified, `IllegalArgumenntException` will be thrown when a method is called with an inappropriate argument._

Good suggestion; blanket statement added.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17523#discussion_r1464179932


More information about the compiler-dev mailing list