RFR: JDK-8042981: Strip type annotations in Types' utility methods [v12]

[Joe Darcy]

On Tue, 23 Jan 2024 23:56:32 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Make make of stripAnnotations more explicit.
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/code/Type.java line 431:
> 
>> 429:         /**
>> 430:          * Note: this visitor only needs to handle cases where 'contained'
>> 431:          * types can be annotated. These cases are described ing JVMS
> 
> typo: `ing`

Fixed.

> test/langtools/tools/javac/processing/model/util/types/TestAnnotationStripping.java line 145:
> 
>> 143:         try {
>> 144:             var result = vacuousTypes.stripAnnotations(tm);
>> 145:             messager.printError("Unexpected non-exceptional result returned" +  result);
> 
> maybe need a space at the end of the string, to separate "returned" from `result`

Good catch.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/8984#discussion_r1464192117
PR Review Comment: https://git.openjdk.org/jdk/pull/8984#discussion_r1464193353