RFR: 8323815: Source launcher should find classes with $ in names [v2]

[Christian Stein]

On Wed, 24 Jan 2024 08:01:09 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

>> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Include more intere'$'ting compilation units
>
> test/langtools/tools/javac/launcher/MultiFileSourceLauncherTests.java line 78:
> 
>> 76:                       public static void main(String... args) throws Exception {
>> 77:                         System.out.println(Class.forName("World$Core"));
>> 78:                         System.out.println(Class.forName("p.q.Unit$123$Fir$t$$econd"));
> 
> I think I would suggest two more tests:
> - one that would (in a separate run) lookup `p.q.Unit$123$Fir$t` (to ensure the search is broad enough)
> - one with a package name with `$`.

Added both tests a suggested.

The first is not test in the separate run, but a separate top-level compilation unit.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17526#discussion_r1465095187