RFR: 8323815: Source launcher should find classes with $ in names [v2]

Christian Stein cstein at openjdk.org
Wed Jan 24 15:33:58 UTC 2024


On Tue, 23 Jan 2024 15:38:31 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> test/langtools/tools/javac/launcher/MultiFileSourceLauncherTests.java line 89:
>> 
>>> 87:                     """);
>>> 88:         var pq = Files.createDirectories(base.resolve("p/q"));
>>> 89:         Files.writeString(pq.resolve("Unit$123.java"),
>> 
>> Maybe keep both tests?
>
> There are plenty tests for canonically named compilation units, thus that wouldn't carry much extra worth.

Re-added the original test.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17526#discussion_r1465095914


More information about the compiler-dev mailing list