RFR: JDK-8042981: Strip type annotations in Types' utility methods [v14]

Jonathan Gibbons jjg at openjdk.org
Thu Jan 25 19:57:41 UTC 2024


On Wed, 24 Jan 2024 06:08:44 GMT, Joe Darcy <darcy at openjdk.org> wrote:

>> Early review for JDK-8042981: "Strip type annotations in Types' utility methods". I work more often in the Element world rather than the Type word of the annotation processing APIs.
>> 
>> The type annotations on primitive types are *not* cleared by the existing annotation clearing mechanisms. I suspect Type.Visitor is missing a case for primitive types. Someone with familiarity with javac's type modeling should take a look; thanks.
>
> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Better describe intentions of stripAnnotations method.

LGTM.

-------------

Marked as reviewed by jjg (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/8984#pullrequestreview-1844572199


More information about the compiler-dev mailing list