RFR: JDK-8042981: Strip type annotations in Types' utility methods [v15]
Jan Lahoda
jlahoda at openjdk.org
Fri Jan 26 17:57:39 UTC 2024
On Thu, 25 Jan 2024 21:35:54 GMT, Joe Darcy <darcy at openjdk.org> wrote:
>> Early review for JDK-8042981: "Strip type annotations in Types' utility methods". I work more often in the Element world rather than the Type word of the annotation processing APIs.
>>
>> The type annotations on primitive types are *not* cleared by the existing annotation clearing mechanisms. I suspect Type.Visitor is missing a case for primitive types. Someone with familiarity with javac's type modeling should take a look; thanks.
>
> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
>
> Update spec and tests for getDeclaredType
Just for completeness, the `getDeclaredType` method has two overloads, so maybe the second overload should get the note that it preserves the annotations as well. No need for re-review.
-------------
Marked as reviewed by jlahoda (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/8984#pullrequestreview-1846236174
More information about the compiler-dev
mailing list