RFR: 8335896: Source launcher should set TCCL [v2]

Alan Bateman alanb at openjdk.org
Sun Jul 21 05:58:43 UTC 2024


On Tue, 16 Jul 2024 08:46:21 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> Please review this change to set the context class loader of the current thread to the in-memory class loader when the `java` launcher is invoked in source mode. Having the source launcher set the TCCL to the in-memory classloader is benefical for scenarious depending on the TCCL being set to the application-loading loader.
>> 
>> For example, the single-argument taking [`ServiceLoader.load(Class)`](https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/util/ServiceLoader.html#load(java.lang.Class)) method creates "a new service loader for the given service type, using the current thread's [context class loader](https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/lang/Thread.html#getContextClassLoader())."
>
> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Clean up implementation

Marked as reviewed by alanb (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/20097#pullrequestreview-2190245034


More information about the compiler-dev mailing list