RFR: 8336754: Remodel TypeAnnotation to "has" instead of "be" an Annotation [v6]

[Andrey Turbanov]

On Wed, 24 Jul 2024 13:00:47 GMT, Chen Liang <liach at openjdk.org> wrote:

>> `TypeAnnotation` is not an annotation, as it should not be used in places like `AnnotationValue.ofAnnotation`. Thus it's remodeled to contain an annotation at a given location instead of to be an annotation.
>> 
>> Depends on #20205.
>
> Chen Liang has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - More refinements from alex
>  - Artifact -> construct
>  - More about Annotation, add equals note

test/langtools/lib/annotations/annotations/classfile/ClassfileInspector.java line 1200:

> 1198:             case RuntimeVisibleTypeAnnotationsAttribute rvattr -> {
> 1199:                 if (expected.matchVisibility(true)) {
> 1200:                     for(var anno : rvattr.annotations()) {

Suggestion:

                    for (var anno : rvattr.annotations()) {

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20247#discussion_r1690305951