RFR: 8336492: Regression in lambda serialization [v3]

Maurizio Cimadamore mcimadamore at openjdk.org
Mon Jul 29 14:41:34 UTC 2024


On Fri, 26 Jul 2024 18:31:52 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add more docs to CaptureScanner, and make fields private/final
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java line 1344:
> 
>> 1342:         CAPTURED_VAR;   // variables in enclosing scope to translated synthetic parameters
>> 1343: 
>> 1344:         boolean propagateAnnotations() {
> 
> suggestion: there is only one use of this method and the method can be rewritten with a ternary operator and probably inlined in its only client

Addressed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20349#discussion_r1695357466


More information about the compiler-dev mailing list