RFR: 8336492: Regression in lambda serialization [v5]

[Maurizio Cimadamore]

On Mon, 29 Jul 2024 14:47:59 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove commented code
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/CaptureScanner.java line 60:
> 
>> 58:      * without any duplicates.
>> 59:      */
>> 60:     private final ListBuffer<VarSymbol> fvs = new ListBuffer<>();
> 
> should this be a set? LinkedHashSet?

note that we use `prepend` to add symbols (which is what the old code used). So, we *could* change to something else, but w/o prepending, we'd create even more ordering issues. Maybe investigate separately?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20349#discussion_r1695565688