[jdk23] RFR: 8337054: JDK 23 RDP2 L10n resource files update

Justin Lu jlu at openjdk.org
Tue Jul 30 20:57:33 UTC 2024


On Tue, 30 Jul 2024 20:17:28 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

> Localization update for JDK23 RDP2
> 
> Please view for enhanced diffs on affected files:
> https://cr.openjdk.org/~dnguyen/output/

LGTM

src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler_zh_CN.properties line 96:

> 94: 
> 95: # 0: kind name, 1: symbol
> 96: compiler.err.already.annotated={0} {1} 已进行批注

Noticeably, _zh_CN_ has updates to a few values that were not updated in the original, but are a result of updated translations by the translation tool. For this particular case it appears that only a space is added, but the contents do appear to be changing as well.

src/jdk.compiler/share/classes/com/sun/tools/javac/resources/launcher_zh_CN.properties line 123:

> 121: 
> 122: # 0: string
> 123: launcher.err.invalid.value.for.source=--source 选项的值无效:{0}

Looks correct. Removal of `\n` is done by white space tool, and standardizes this value with the original and other localized values that do not end with `\n`.

-------------

Marked as reviewed by jlu (Committer).

PR Review: https://git.openjdk.org/jdk/pull/20394#pullrequestreview-2208619181
PR Review Comment: https://git.openjdk.org/jdk/pull/20394#discussion_r1697548560
PR Review Comment: https://git.openjdk.org/jdk/pull/20394#discussion_r1697541280


More information about the compiler-dev mailing list