RFR: 8333748: javap crash - Fatal error: Unmatched bit position 0x2 for location CLASS [v4]

[Adam Sotona]

On Mon, 17 Jun 2024 17:38:56 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Currently, javap crashes for class files that have set non-zero values for undefined access flag bits, as `java.lang.reflect.AccessFlag.maskToAccessFlag` and `java.lang.classfile.AccessFlags.flags` fail. In contrast, the JVMS, though asking for these bits to be set to 0, requires VM to proceed and ignore these bits. javap should emulate the VM behavior and proceed rendering, ignoring these undefined bits.
>> 
>> In addition, a few bytecode generation utilities in the JDK set unused bits, such as in `java.lang.invoke.MethodHandleImpl.BindCaller#generateInvokerTemplate` and `java.lang.invoke.GenerateJLIClassesHelper#generateCodeBytesForLFs`. Those can be updated in a later cleanup.
>
> Chen Liang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Improved error message

Now it looks good to me, thanks.

-------------

Marked as reviewed by asotona (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19708#pullrequestreview-2123504238