RFR: 8334295: CTW: update modules

Aleksey Shipilev shade at openjdk.org
Thu Jun 20 05:31:42 UTC 2024


On Tue, 18 Jun 2024 06:29:40 GMT, Evgeny Nikitin <enikitin at openjdk.org> wrote:

>> test/hotspot/jtreg/applications/ctw/modules/generate.bash line 33:
>> 
>>> 31:     cat > $file <<EOF
>>> 32: /*
>>> 33:  * Copyright (c) 2017, 2024, Oracle and/or its affiliates. All rights reserved.
>> 
>> Hm. So if the date had changed here, why it did not change in the existing files?
>
> 1. I generated only the files for the new modules, not changing the existing ones (as they would not change);
> 2. I've manually edited the generated headers, removing the "2017" part. I'm not a layer, but it seems reasonable as the new files' code didn't exist before 2024, despite it being a standard and template one.

IIRC, there is already a precedent for regenerating and updating all the files when template file change, e.g. in ByteBuffers / VarHandles. The problem with manual intervention is that a next person that regenerates the files from the template would expect no changes in files when template did not change.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19738#discussion_r1644062395


More information about the compiler-dev mailing list