RFR: 8317611: Add a tool like jdeprscan to find usage of restricted methods [v5]

Alan Bateman alanb at openjdk.org
Thu Jun 20 17:01:17 UTC 2024


On Tue, 18 Jun 2024 16:35:10 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update man page header to be consisten with the others
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/platform/JDKPlatformProvider.java line 93:
> 
>> 91:     }
>> 92: 
>> 93:     public PlatformDescription getPlatformTrusted(String platformName) {
> 
> I noticed that `getPlatform` was not throwing an exception if the release was not valid, which then later results in an NPE. I've added an explicit check here instead. The caller can then catch the exception.

I see the "options" arg is not used so maybe another approach here is a one-arg getPlatform that throws PlatformNotSupported and then migrate the other usages at another time. 

(This is just a passing comment, not important for the core of this feature).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19774#discussion_r1647877795


More information about the compiler-dev mailing list