RFR: 8317611: Add a tool like jdeprscan to find usage of restricted methods [v7]

Jorn Vernee jvernee at openjdk.org
Fri Jun 21 20:54:17 UTC 2024


On Fri, 21 Jun 2024 18:38:07 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> test/langtools/tools/jnativescan/TestJNativeScan.java line 174:
>> 
>>> 172:                                   "-add-modules", "org.singlejar,org.myapp",
>>> 173:                                   "--print-native-access"))
>>> 174:                 .stdoutShouldContain("org.singlejar")
>> 
>> It is a small thing, bu was there a consideration for a stronger assert on the output, checking that the output is precisely something like `--enable-native-access org.lib,org.service,org.singlejar`? Would require that the output is stable, which may be tricky, but also not a bad property. Just an idea for consideration.
>
> Good point. The result should be 'clean' and directly forward-able to `--enable-native-access`. (So in this case it should be exactly `org.singlejar`)

I'm fixing this test, and also making the output sorted. That is required for the output stability, but I also thought that would be a nice property in case a user wants to diff the tool's outputs.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19774#discussion_r1649418854


More information about the compiler-dev mailing list