RFR: 8335159: Move method reference to lambda desugaring before Lower [v2]

Jan Lahoda jlahoda at openjdk.org
Fri Jun 28 12:21:26 UTC 2024


On Thu, 27 Jun 2024 10:03:23 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> As we recently [moved](https://github.com/openjdk/jdk/pull/19836) the translation of "simple" method references from `LambdaToMethod` to `Lower`, it became clearer that this step in fact would benefit from running even *earlier*, as it depends on the synthetic casts generated by `TransTypes` (e.g. if one or more desugared lambda parameters have a type that is either an intersection or a union type).
>> Moving the translation earlier would allow us not to *guess* which casts would need to be introduced, and just running `TransTypes::translate` on the desugaring code would take into account the type mismatches.
>
> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Address review comment

Looks OK to me.

-------------

Marked as reviewed by jlahoda (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19903#pullrequestreview-2147864169


More information about the compiler-dev mailing list