RFR: 8334248: Invalid error for early construction local class constructor method reference [v2]

[Maurizio Cimadamore]

On Thu, 27 Jun 2024 12:42:44 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix test summary
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Resolve.java line 3772:
> 
>> 3770:         Env<AttrContext> env1 = env;
>> 3771:         boolean staticOnly = false;
>> 3772:         Symbol bestSoFar = varNotFound;
> 
> nit: it seems like this variable either holds this value, varNotFound, or an error but never the symbol we are looking for, so probably the name should reflect this?

I've renamed this to `firstError`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19904#discussion_r1659110498