RFR: 8325362: Allow to create a simple in-memory input JavaFileObject [v3]
Jim Laskey
jlaskey at openjdk.org
Fri Mar 8 12:11:53 UTC 2024
On Fri, 8 Mar 2024 10:19:17 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:
>> There are many subtypes of `SimpleJavaFileObject` scattered through various codebases, majority of them looking like:
>>
>>
>> private static class JavaSource extends SimpleJavaFileObject {
>>
>> private String code;
>>
>> public JavaSource(String code) {
>> super(URI.create("myfo:/Test.java"), JavaFileObject.Kind.SOURCE);
>> this.code = code;
>> }
>>
>> @Override
>> public CharSequence getCharContent(boolean ignoreEncodingErrors) {
>> return code;
>> }
>> }
>>
>>
>> The proposal herein is a to add a factory method that would return an implementation of `SimpleJavaFileObject` based on the provided `URI` and source content.
>>
>> The CSR for this change is available for review here:
>> https://bugs.openjdk.org/browse/JDK-8327536
>
> Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision:
>
> Updating license headers.
LGTM
-------------
Marked as reviewed by jlaskey (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/18149#pullrequestreview-1924745292
More information about the compiler-dev
mailing list