RFR: 8323605: Java source launcher should not require `--source ...` to enable preview [v6]
David Holmes
dholmes at openjdk.org
Wed Mar 13 06:40:19 UTC 2024
On Tue, 12 Mar 2024 16:06:24 GMT, Christian Stein <cstein at openjdk.org> wrote:
>> Please review this PR targeting the source launcher that instead of throwing an error reading _"--enable-preview must be used with --source"_ adds the required compiler arguments on-the-fly.
>>
>> The add arguments are `--release` and `feature`, with `feature` being the release feature number of the current Java runtime as acquired by `Runtime.version().feature()`.
>
> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
>
> Remove superfluous backticks
manpage update is good. Thanks
-------------
Marked as reviewed by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/17731#pullrequestreview-1933262272
More information about the compiler-dev
mailing list