RFR: 8328649: Disallow enclosing instances for local classes in constructor prologues

[Vicente Romero]

On Thu, 21 Mar 2024 02:10:09 GMT, Archie Cobbs <acobbs at openjdk.org> wrote:

> A local class declared in a static context is not supposed to have an immediately enclosing instance (§15.9.2). That includes local classes declared in constructors prior to `super()` (during the "constructor prologue" in the new lingo).
> 
> However, the compiler is allowing code like this to successfully compile:
> 
> import java.util.concurrent.atomic.*;
> public class Test extends AtomicReference<Object> {
>   
>     public Test() {
>         super(switch (0) {
>           default -> {
>               class Local { { Test.this.hashCode(); } }   // this should fail
>               yield null;
>             }
>         });
>     }
> }
> 
> This patch fixes the "leak".

looks good to me

-------------

Marked as reviewed by vromero (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18416#pullrequestreview-1953493763