RFR: 8325805: Compiler Implementation for Flexible Constructor Bodies (Second Preview)

[Archie Cobbs]

On Mon, 4 Mar 2024 03:42:29 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> Is there a default copyright for such a file without a copyright header? I would assume it's simply copyright Oracle Corporation, all rights reserved?
>> 
>> Also please bear with my comment, I know you feel impatient but I've never seen this tag before. The usage of `/nodynamiccopyright/` seems to be only in javac for preservation of hardcoded line number purposes so I was ignorant about it, as I mostly worked with other parts of the JDK.
>
>> Also please bear with my comment, I know you feel impatient but I've never seen this tag before. The usage of `/nodynamiccopyright/` seems to be only in javac for preservation of hardcoded line number purposes so I was ignorant about it, as I mostly worked with other parts of the JDK.
> 
> Take it easy. I didn't feel impatient.  Nobody can know everything. It is just a point that you don't know. Now you know it during reviewing. So, don't worry about making mistakes and keeping on reviewing, then you can learn more.
> 
>> Is there a default copyright for such a file without a copyright header? I would assume it's simply copyright Oracle Corporation, all rights reserved?
> 
> Now, it is my run not to know.

For reference, here's where this is discussed in the developer's guide: https://openjdk.org/groups/compiler/tests.html

See section 10 "Golden file tests".

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18088#discussion_r1511285106