RFR: 8331027: JDK's ct.sym file packs corrupted module-info classes

Thu May 2 07:05:54 UTC 2024

On Wed, 1 May 2024 11:18:36 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

> When writing the `ModuleMainClass` attribute, `CreateSymbols` uses an UTF8 entry (incorrect), instead of a Class_info (correct). This patch fixes that.

Looks good to me.

test/langtools/tools/javac/platform/createsymbols/CreateSymbolsTestImpl.java line 1104:

> 1102:         CreateSymbols.EXTENSION = ".class";
> 1103: 
> 1104:         deleteRecursively(ctSym);

Is double deletion needed for some kind of race condition safety?

-------------

Marked as reviewed by asotona (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19031#pullrequestreview-2034978645
PR Review Comment: https://git.openjdk.org/jdk/pull/19031#discussion_r1587160139