RFR: 8329718: Incorrect `@since` tags in elements in jdk.compiler and java.compiler

Joe Darcy darcy at openjdk.org
Thu May 2 16:35:52 UTC 2024


On Fri, 26 Apr 2024 11:05:03 GMT, Nizar Benalla <duke at openjdk.org> wrote:

> This PR aims to add `@since` tags in elements in both `jdk.compiler` and `java.compiler`.
> A lot of these changes have to do with handling of preview features.
> 
> The existing rules for handling of `@since` for preview elements:
> - When an element is still marked as preview, the `@since` should be the first JDK release where the element was added.
> - If the element is no longer marked as preview, the `@since` should be the first JDK release where it was no longer preview.
> 
> It is tricky to check these, the way preview elements were annotated before the inroduction of `@Previewfeature` in JDK 17:
> - in jdk 12-13 they were annotated with `@Deprecated(forRemoval=true, since=...)`
> - in jdk 14-15 they were annotated with `@jdk.internal.preview` or with `{@preview Associated with ....` in the `javadoc` comment
> 
> If you're reviewing these changes, Thanks!

The java.compiler changes looks fine.

-------------

Marked as reviewed by darcy (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18972#pullrequestreview-2036266163


More information about the compiler-dev mailing list