RFR: 8320396: Class-File API ClassModel::verify should include checks from hotspot/share/classfile/classFileParser.cpp [v4]

[Adam Sotona]

On Tue, 7 May 2024 18:51:28 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Adam Sotona has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 28 commits:
>> 
>>  - Merge branch 'master' into JDK-8320396-verifier-extension
>>  - added references to jvms
>>  - Merge remote-tracking branch 'openjdk/master' into JDK-8320396-verifier-extension
>>  - work in progress
>>  - work in progress
>>  - work in progress
>>  - work in progress
>>  - work in progress
>>  - removed string templates from test
>>  - work in progress
>>  - ... and 18 more: https://git.openjdk.org/jdk/compare/ae82405f...3ebc780a
>
> src/java.base/share/classes/jdk/internal/classfile/impl/verifier/VerificationWrapper.java line 134:
> 
>> 132:         }
>> 133: 
>> 134:         String parameters() {
> 
> We should just use the mtd's displayDescriptor, a class file can have bridge methods with covariant return types and the bridge may be broken while the concrete method is ok.

I preferred readability of the error messages over full information. 
Broken covariant is a corner case and exact method can be found even from the reduced info provided.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16809#discussion_r1595244945