RFR: 8331855: Convert jdk.jdeps jdeprscan and jdeps to use the Classfile API [v2]
Chen Liang
liach at openjdk.org
Mon May 13 10:14:07 UTC 2024
On Sun, 12 May 2024 02:42:32 GMT, Chen Liang <liach at openjdk.org> wrote:
>> Summary of the changes:
>> - Moved `com.sun.tools.classfile.Dependency` and `Dependencies` to jdeps; they are exclusively used by jdeps in sources, and they are not used in any tests too. This will ease the removal of `com.sun.tools.classfile` later.
>> - A few visitor patterns have been rewritten with pattern matching, notably in:
>> - `CPEntries`/`CPSelector` (removed)
>> - `Dependencies.BasicDependencyFinder.Visitor` has been rewritten to use pattern matching to capture dependencies.
>> - `MethodSig` and its tests have been removed in favor of `MethodTypeDesc`.
>> - Otherwise, the changes are mostly mechanical replacements.
>>
>> All tests in `test/langtools/tools/jdeprscan` and `test/langtools/tools/jdeps` pass.
>
> Chen Liang has updated the pull request incrementally with one additional commit since the last revision:
>
> Migrate omitted getdeps test in langtools
@asotona Requesting your review for this and the other test migration patch.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/19193#issuecomment-2107175526
More information about the compiler-dev
mailing list