RFR: 8332236: javac crashes with module imports and implicitly declared class

Vicente Romero vromero at openjdk.org
Tue May 14 19:38:07 UTC 2024


On Tue, 14 May 2024 14:54:45 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

> When parsing implicitly declared class, javac wraps the elements it finds in the file by the implicitly declared (and created) class. But, it avoids wrapping imports. But, accidentally, it is wrapping the module imports into the class, which then inevitably fails.
> 
> The proposed fix is to simply handle the the module imports in the same way normal imports are handled.

looks good

-------------

Marked as reviewed by vromero (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19232#pullrequestreview-2056243703


More information about the compiler-dev mailing list