RFR: 8320396: Class-File API ClassModel::verify should include checks from hotspot/share/classfile/classFileParser.cpp [v6]

Adam Sotona asotona at openjdk.org
Wed May 15 10:47:24 UTC 2024


On Wed, 15 May 2024 09:45:24 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   applied the suggested changes
>
> src/java.base/share/classes/jdk/internal/classfile/impl/verifier/ParserVerifier.java line 306:
> 
>> 304:                 size = 1;
>> 305:                 for (var ans : aa.parameterAnnotations()) {
>> 306:                     size += annotationsSize(ans);
> 
> Shouldn't we call the new method here (passing `parameterAnnotations`) ?

Yes, I've compacted it a bit more, thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16809#discussion_r1601399335


More information about the compiler-dev mailing list