RFR: 8129418: JShell: better highlighting of errors in imports on demand

[Jan Lahoda]

On Thu, 2 May 2024 23:42:38 GMT, Nizar Benalla <duke at openjdk.org> wrote:

> When Type-Import-on-Demand fails, we now point the position of the first incorrect PackageOrTypeName which clearly isn't package, a class,or an interface.
> 
> old behavior:
> 
> |  Welcome to JShell -- Version 22.0.1
> |  For an introduction type: /help intro
> 
> jshell> import unknown.*;
> |  Error:
> |  package unknown does not exist
> |  import unknown.*;
> |  ^
> 
> New behavior:
> 
> |  Welcome to JShell -- Version 23-internal
> |  For an introduction type: /help intro
> 
> jshell> import unknown.*;
> |  Error:
> |  package unknown does not exist
> |  import unknown.*;
> |         ^-----^
> 
> 
> 
> jshell> import unknown.unknown.unknown.*;
> |  Error:
> |  package unknown.unknown.unknown does not exist
> |  import unknown.unknown.unknown.*;
> |         ^---------------------^

Looks good to me.

-------------

Marked as reviewed by jlahoda (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19073#pullrequestreview-2061725383