RFR: 8324809: compiler can crash with SOE while proving if two recursive types are disjoint [v2]

[Vicente Romero]

On Thu, 16 May 2024 16:46:09 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Vicente Romero has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   addressing review comments
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/code/Types.java line 4738:
> 
>> 4736:         boolean rewriteTypeVars;
>> 4737:         // map to avoid visiting same type argument twice, like in Foo<T>.Bar<T>
>> 4738:         Map<Type, Type> argMap = new HashMap<>();
> 
> Do we need to use both a map and a set, or can we just use the map?

I think yes and in any case the code is more readable, me thinks, with both than using only one

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19194#discussion_r1605080261