RFR: 8332497: javac crashes when annotation processing runs on program with module imports [v4]

Evemose duke at openjdk.org
Mon May 20 07:52:01 UTC 2024


On Mon, 20 May 2024 07:38:38 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

> The test is not wrong, but could be made shorter like here: https://github.com/lahodaj/jdk/blob/8e4c9f4091f443766e5f009317661260154a33a8/test/langtools/tools/javac/ImportModule.java#L750
> 
> Also, the similar `com.sun.tools.javac.tree.TreeTranslator` could also be made consistent and handle module imports. Although I doubt there is an end-user way to see the difference (I am not aware about any whole-AST translation in javac; only per-class translations; for the internal scanner, it is also more common to scan only classes, I think).

Thanks for suggestion. Is it ok to just out bug-related test into some pre-existing test class? I just saw that issue-related tests are all in separate folders so figured its how it should be. Also will whe processing run if there is no annotated elemnts at all? If i remeber correctly, it will not

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19292#issuecomment-2119873332


More information about the compiler-dev mailing list