RFR: 8332497: javac crashes when annotation processing runs on program with module imports [v8]

[Thomas Stuefe]

On Wed, 22 May 2024 11:05:21 GMT, Evemose <duke at openjdk.org> wrote:

>> Fix is pretty simple: visitModuleImport in com.sun.tools.javac.tree.TreeScanner has notbeen overriden, so defaulted to Visitor::visitModuleImport, which forwards to Visitor::visitTree, which is also not overriden, and, therefore, threw AssertionError. 
>> 
>> PS: Im not even sure how it worked before without crashing, seems like there is some intermidiate implementation between this TreeScanner and actual scanners because otherwise it should have resultedin compile error the moment it encounter module importin any visitor
>
> Evemose has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Converted test to extend JavacTestingAbstractProcessor

Drive-by comment: I was curious about the "crashes" in the bug description, but this is no crash. It is an AssertionError. Could we please improve JBS issue title and PR title to say that?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19292#issuecomment-2124535423