RFR: 8332497: javac crashes when annotation processing runs on program with module imports [v7]

Evemose duke at openjdk.org
Wed May 22 11:15:04 UTC 2024


On Tue, 21 May 2024 16:09:10 GMT, Joe Darcy <darcy at openjdk.org> wrote:

>> Evemose has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Added legal header and renamed test
>
> test/langtools/tools/javac/annotations/ModuleImportProcessingTest.java line 1:
> 
>> 1: /*
> 
> Looks like this test would work better as a "native" annotation processing test.
> 
> I recommend look in the `test/langtools/tools/javac/processing` directory hierarchy, specifically for test classes that subclass `JavacTestingAbstractProcessor`. HTH

Thanks for the hint. I refactored the test, It looks much better now

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19292#discussion_r1609762277


More information about the compiler-dev mailing list