RFR: 8329718: Incorrect `@since` tags in elements in jdk.compiler and java.compiler [v2]

Nizar Benalla nbenalla at openjdk.org
Wed May 22 14:01:20 UTC 2024


> This PR aims to add `@since` tags in elements in both `jdk.compiler` and `java.compiler`.
> A lot of these changes have to do with handling of preview features.
> 
> The existing rules for handling of `@since` for preview elements:
> - When an element is still marked as preview, the `@since` should be the first JDK release where the element was added.
> - If the element is no longer marked as preview, the `@since` should be the first JDK release where it was no longer preview.
> 
> It is tricky to check these, the way preview elements were annotated before the inroduction of `@Previewfeature` in JDK 17:
> - in jdk 12-13 they were annotated with `@Deprecated(forRemoval=true, since=...)`
> - in jdk 14-15 they were annotated with `@jdk.internal.preview` or with `{@preview Associated with ....` in the `javadoc` comment
> 
> If you're reviewing these changes, Thanks!

Nizar Benalla has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:

 - Merge branch 'master' into 8329718
 - small change, `visitYield` went out of preview in JDK 14
 - add `@since` tags to `java.compiler`
 - add `@since` tags to `jdk.compiler`

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18972/files
  - new: https://git.openjdk.org/jdk/pull/18972/files/558abe6e..38514761

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18972&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18972&range=00-01

  Stats: 87199 lines in 2563 files changed: 55202 ins; 21108 del; 10889 mod
  Patch: https://git.openjdk.org/jdk/pull/18972.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18972/head:pull/18972

PR: https://git.openjdk.org/jdk/pull/18972


More information about the compiler-dev mailing list