RFR: 8331348: Some incremental builds deposit files in the make directory

Magnus Ihse Bursie ihse at openjdk.org
Thu May 23 10:36:05 UTC 2024


On Wed, 22 May 2024 19:07:59 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

>> Please review this small change. Passes tier 1-3.
>> 
>> In case of fatal errors or if a hidden option is passed to the compiler, a report with the parameters passed to it is printed to a file in the `@-file` format, this makes it easier for us to reproduce the bug. And for users submitting bug reports.
>> Some of these files were being deposited in the current directory during OpenJDK builds, now they are moved to the temp dir.
>> Writing to the console only is not an option because of the large number of arguments that can be passed to the compiler.
>> By convention, a number of arguments is printed to the console if an error occurs while writing to the file.
>> Some also suggested adding a message as to why this file exist.
>> 
>> TIA
>> 
>> I see the bot is complaining due to the fix version but I think it can be changed, if this is approved.
>
> FWIW, I don't have a strong opinion on where the diagnostic file should be written. But it would be good to investigate why javac crashes, and fix that, not only move the files.

@lahodaj Absolutely! But that is a completely separate issue from this, that deals with how javac spews log files all around itself...

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19338#issuecomment-2126774472


More information about the compiler-dev mailing list